glibc: use (lib.getBin pkgsBuildBuild.glibc) to generate locales#262881
Merged
2 commits merged intomasterfrom Oct 26, 2023
unknown repository
Merged
glibc: use (lib.getBin pkgsBuildBuild.glibc) to generate locales#2628812 commits merged intomasterfrom unknown repository
2 commits merged intomasterfrom
unknown repository
Conversation
This is an alternative resolution of the problem identified in #259964 which stated that "glibc depends on buildPackages.glibc for locale things. buildPackages.glibc depended on buildPackages.libgcc, which, since it's GCC, depends on the target's bintools, which depend on the target's glibc, which, again, depends on buildPackages.glibc, causing an infinute recursion when evaluating buildPackages.glibc when glibc hasn't come from stdenv (e.g. on musl)." The fact that we use pkgsBuildHost.glibc instead of pkgsBuildBuild.glibc to generate the locales has always been a gross hack. If we simply remove the gross hack the circularity goes away.
ghost
mentioned this pull request
12 tasks
ofborg
bot
added
10.rebuild-darwin: 0
ghost
marked this pull request as ready for review
Member
|
@ofborg build pkgsMusl.pkgsCross.gnu64.hello |
Author
|
@ofborg build pkgsMusl.pkgsCross.gnu64.hello Should work now. |
Author
|
pkgsMusl.pkgsCross.gnu64.hello on x86_64-linux — Success |
alyssais
approved these changes
Oct 25, 2023
Member
alyssais
left a comment
alyssais
left a comment
There was a problem hiding this comment.
Either approach seems equally good to me, so if you like this one better, go ahead!
delroth
added
the
12.approvals: 1
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is an alternative resolution of the problem identified in
#259964
which stated that "glibc depends on buildPackages.glibc for locale things. buildPackages.glibc depended on buildPackages.libgcc, which, since it's GCC, depends on the target's bintools, which depend on the target's glibc, which, again, depends on buildPackages.glibc, causing an infinute recursion when evaluating buildPackages.glibc when glibc hasn't come from stdenv (e.g. on musl)."
The fact that we use pkgsBuildHost.glibc instead of pkgsBuildBuild.glibc to generate the locales has always been a gross hack. If we simply remove the gross hack the circularity goes away.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)